[FIR-317] Align the flydocs badge neutral chip with the warm ramp - #60
Merged
Conversation
The badge's neutral-chip role in Flydocs points at the warm ramp (#f6f3ec), not the cool neutral-100 every other themed surface reuses. Pin `--ff-badge-neutral-bg`, the existing component token consumed by ff-badge, in the flydocs playground fixture so the neutral chip matches without touching any other neutral-100 consumer. Dark mode is left unset on purpose: the source product's own dark theme doesn't repin this role either, so the badge falls back to its already dark-repinned --ff-color-neutral-100.
Update the neutral-ramp caveat in the token equivalence doc and flip the ff-badge parity verdict from a flagged delta to resolved, now that the chip resolves through its own overridable component token pinned to the warm value Flydocs' own neutral-chip role uses.
The flydocs light block is scoped to `:root[data-brand='flydocs']` with no `data-theme` condition, so any property it sets stays in effect under `[data-theme='dark']` unless the dark block explicitly cancels it. `--ff-badge-neutral-bg` was missing that reset, so the warm light pin was leaking into dark mode and washing out the neutral badge (most visibly the tab-bar's count badge). Reset it to `initial` in the dark block so the badge correctly falls through to its already dark-repinned `--ff-color-neutral-100` fallback.
The badge's neutral chip now renders warm under the flydocs light theme. Dark is byte-identical to before (the token stays unset there), so only the light baseline needed a refresh. Verified with a full playground-e2e run (15/15 green, no other baseline moved).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves the badge neutral-chip parity delta flagged by the FF-CAT-20 gate (FIR-317, from FIR-294's parity report): the flydocs playground theme now pins
--ff-badge-neutral-bg(component token shipped in design-system 0.4.0 by FIR-316 — zero package changes) to Flydocs' warm neutral-chip role#f6f3ec, light mode only.initialin the dark block so the badge falls through to the dark neutral repin — fixes a light-into-dark leak caught by pixel-sampling during re-baselining.seed_vr_baselinesdispatch after merge).How to verify
pnpm nx e2e playground-e2e— 15/15 (run twice, stable).pnpm nx serve playground --port 4300→ /parity, flydocs theme: neutral badge reads warm in light, unchanged in dark.Traceability
Board ticket without owning PASO: key in branch and commit subjects.